Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binaryen dependency feature #113

Closed
ascjones opened this issue Nov 30, 2020 · 1 comment · Fixed by #168
Closed

binaryen dependency feature #113

ascjones opened this issue Nov 30, 2020 · 1 comment · Fixed by #168
Assignees
Labels
enhancement New feature or request

Comments

@ascjones
Copy link
Collaborator

ascjones commented Nov 30, 2020

In #95 we add the binaryen as a dependency, rather than requiring manual installation. However this

  • Increases the build time which we want to keep as fast and easy as possible. (edit: it might not be by much? need to confirm with fresh build)
  • Takes up quite a lot of disk space
  • Requires the prerequisities to be installed.

We could still provide this but behind a feature, and default to using an installed binary, and perhaps we could provide better information to be able to download a prebuilt binary e.g. there is one here https://packages.debian.org/buster/binaryen.

Potentially we could detect the presence of the binary on the PATH, and then choose whether to enable this feature but it would require some trickery in build.rs so not sure about that.

/cc @Robbepop

@ascjones ascjones added the enhancement New feature or request label Nov 30, 2020
@Robbepop
Copy link
Contributor

Potentially we could detect the presence of the binary on the PATH, and then choose whether to enable this feature but it would require some trickery in build.rs so not sure about that.

We do want exactly this. User should not need to specify some crate features to make this happen manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants