Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues identified in porting code to new repo #9

Closed
annekainicUSDS opened this issue Apr 17, 2018 · 2 comments
Closed

Issues identified in porting code to new repo #9

annekainicUSDS opened this issue Apr 17, 2018 · 2 comments
Labels
[practice] engineering Engineering related work [type] research User or Product research

Comments

@annekainicUSDS
Copy link
Contributor

annekainicUSDS commented Apr 17, 2018

  1. environment.js has vets.gov-specific logic. Might need to create a separate config file for this information that a user will have to specify in setup.
    --> new ticket: Create an environment variables file #50
  2. What to do about the nonMilitaryJobs definition (it imports an education-specific component)
    --> new ticket: pull out nonMilitaryJobs from library #51
  3. What to do about PrivacyAgreement component
    --> new ticket: PrivacyAgreement refactor #53
  4. Figure out how to port over this PR: https://github.com/department-of-veterans-affairs/vets-website/pull/7334/files
    --> no longer necessary because this is only used as part of the save in progress code, which we have extracted out of the library
  5. FileField doesn't return the response as expected. Look into FileField behavior and how it interacts with the server.
    --> new ticket: Discovery on FileField (file uploads) #52
@annekainicUSDS annekainicUSDS added the [practice] engineering Engineering related work label Apr 17, 2018
@ju-liem ju-liem added the [type] research User or Product research label May 3, 2018
@ju-liem
Copy link
Contributor

ju-liem commented May 3, 2018

After investigating each, new tickets for needed work should be created.

@annekainicUSDS
Copy link
Contributor Author

Investigated each of the items above and have created new tickets for them (see description for new ticket links). Closing as this is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[practice] engineering Engineering related work [type] research User or Product research
Projects
None yet
Development

No branches or pull requests

2 participants