Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo port of forms code from vets-website #62

Closed
annekainicUSDS opened this issue May 29, 2018 · 2 comments
Closed

Redo port of forms code from vets-website #62

annekainicUSDS opened this issue May 29, 2018 · 2 comments
Assignees
Labels
[practice] engineering Engineering related work

Comments

@annekainicUSDS
Copy link
Contributor

The original port I completed became out of sync because new changes continued to be merged into vets-website and it became unmanageable to keep the two versions of the codebase in sync while we waited to switch applications on Vets.gov to use the new repo. Redoing the port while we implement a code freeze for a few days on vets-website to keep the port clean.

@annekainicUSDS annekainicUSDS added the [practice] engineering Engineering related work label May 29, 2018
@annekainicUSDS annekainicUSDS self-assigned this May 29, 2018
@annekainicUSDS
Copy link
Contributor Author

annekainicUSDS commented May 29, 2018

Things that remain to be changed on vets-website:

  • Remove getInactivePages and use the version in us-forms-system in HCA
  • Remove timeFromNow
  • Remove PrivacyAgreement
  • Remove schemaform-utils.jsx

Things that remain to be changed in us-forms-system:

  • Move unit test for timeFromNow into helpers unit test file
  • References to __BUILDTYPE__ --> right now this exists only in SubmitButtons.jsx
  • Write a new, generic version of SubmitButtons, it's too specific to Vets.gov

@annekainicUSDS
Copy link
Contributor Author

Complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[practice] engineering Engineering related work
Projects
None yet
Development

No branches or pull requests

1 participant