Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 16 #230

Closed
annekainicUSDS opened this issue Aug 17, 2018 · 3 comments
Closed

Upgrade to React 16 #230

annekainicUSDS opened this issue Aug 17, 2018 · 3 comments
Assignees
Labels
[practice] engineering Engineering related work [status] not prioritized Not necessarily won't-fix but near-term out of scope. [type] debt Tech debt, refactors, maintenance issues
Milestone

Comments

@annekainicUSDS
Copy link
Contributor

It's been out for almost a year now, so we should upgrade to it! May need to consider the impact on users of the library (Vets.gov is still stuck on v15, though they want to upgrade too: https://github.com/department-of-veterans-affairs/vets.gov-team/issues/9143).

@annekainicUSDS annekainicUSDS added [practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues labels Aug 17, 2018
@annekainicUSDS annekainicUSDS self-assigned this Aug 28, 2018
@annekainicUSDS
Copy link
Contributor Author

Digging into the React changelog, I don't think there are any breaking changes that would prevent us from upgrading to React 16. However, there are a couple of complications:

  1. Our primary dependency, rjsf, is currently using React 15. We're considering pulling what we need out of rjsf and into our library, which would give us greater control of the dependency management, but we haven't totally figured out that work yet.
  2. React 17 is going to be deprecating a bunch of the lifecycle functions. We can still use the lifecycle functions we currently use, but it will result in warnings, beginning in React 16. We may want to look into the work involved in upgrading those lifecycle functions along with the upgrade to React 16 before starting that work.

For these reasons, I think we're going to begin by upgrading react-router 4 and then revisit this work. @dmethvin-gov let me know if you agree!

@jcmeloni-usds jcmeloni-usds added this to the 2.0.0-alpha.2 milestone Sep 20, 2018
@jcmeloni-usds
Copy link
Contributor

Per discussions, moved this to phase 2

@annekainicUSDS annekainicUSDS added the [status] not prioritized Not necessarily won't-fix but near-term out of scope. label Dec 27, 2018
@dmethvin-gov
Copy link
Contributor

Fixed in 1.x-stable by #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[practice] engineering Engineering related work [status] not prioritized Not necessarily won't-fix but near-term out of scope. [type] debt Tech debt, refactors, maintenance issues
Projects
None yet
Development

No branches or pull requests

3 participants