Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove VA code dependencies #113

Closed
dmethvin-gov opened this issue Jun 26, 2018 · 2 comments
Closed

Refactor to remove VA code dependencies #113

dmethvin-gov opened this issue Jun 26, 2018 · 2 comments
Labels
[practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues

Comments

@dmethvin-gov
Copy link
Contributor

This is similar to #56 but on the code side. Many of the js/jsx files include dependencies from department-of-veterans-affairs, such as SelectWidget.jsx which pulls in asNumber and RadioWidget.js for ExpandingGroup. These should be refactored so that either 1) we have our own copy, 2) the VA site gets it from us-forms-system, or 3) both we and the VA site get it from some newly created component.
@dmethvin-gov dmethvin-gov added [practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues labels Jun 26, 2018
@jcmeloni-usds
Copy link
Contributor

@dmethvin-gov Is this still a thing that's in the debt bucket, or has work progressed past this? Thanks!

@dmethvin-gov
Copy link
Contributor Author

Still here, this is due to our use of the forked react-jsonschema-form which will be addressed by #141 so I'll close this as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[practice] engineering Engineering related work [type] debt Tech debt, refactors, maintenance issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcmeloni-usds @dmethvin-gov