-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for all non-census sources #1899
Merged
mattbowen-usds
merged 27 commits into
emma-nechamkin/release/score-narwhal
from
mattbowen-usds/1848-test-all-sources
Sep 19, 2022
Merged
Add tests for all non-census sources #1899
mattbowen-usds
merged 27 commits into
emma-nechamkin/release/score-narwhal
from
mattbowen-usds/1848-test-all-sources
Sep 19, 2022
Commits on Sep 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 025b0b1 - Browse repository at this point
Copy the full SHA 025b0b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba32746 - Browse repository at this point
Copy the full SHA ba32746View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a3614c - Browse repository at this point
Copy the full SHA 8a3614cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5579305 - Browse repository at this point
Copy the full SHA 5579305View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16c8042 - Browse repository at this point
Copy the full SHA 16c8042View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbd78c7 - Browse repository at this point
Copy the full SHA bbd78c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72feee2 - Browse repository at this point
Copy the full SHA 72feee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebee416 - Browse repository at this point
Copy the full SHA ebee416View commit details -
Configuration menu - View commit details
-
Copy full SHA for eec4db2 - Browse repository at this point
Copy the full SHA eec4db2View commit details -
Update tests for new multi-CSV but (#1848)
Lucas updated the CDC life expectancy data to handle a bug where two states are missing from the US Overall download. Since virtually none of our other ETL classes download multiple CSVs directly like this, it required a pretty invasive new mocking strategy.
Configuration menu - View commit details
-
Copy full SHA for a61ed6e - Browse repository at this point
Copy the full SHA a61ed6eView commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 28b4d73 - Browse repository at this point
Copy the full SHA 28b4d73View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc957aa - Browse repository at this point
Copy the full SHA fc957aaView commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for eea77c2 - Browse repository at this point
Copy the full SHA eea77c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f455a98 - Browse repository at this point
Copy the full SHA f455a98View commit details -
Configuration menu - View commit details
-
Copy full SHA for ecdd761 - Browse repository at this point
Copy the full SHA ecdd761View commit details -
Configuration menu - View commit details
-
Copy full SHA for 922a3ba - Browse repository at this point
Copy the full SHA 922a3baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73036b2 - Browse repository at this point
Copy the full SHA 73036b2View commit details
Commits on Sep 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 68c83b2 - Browse repository at this point
Copy the full SHA 68c83b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 463ec06 - Browse repository at this point
Copy the full SHA 463ec06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 665d136 - Browse repository at this point
Copy the full SHA 665d136View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ac68d - Browse repository at this point
Copy the full SHA b8ac68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 875bff2 - Browse repository at this point
Copy the full SHA 875bff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ad7a7d - Browse repository at this point
Copy the full SHA 2ad7a7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c74f68d - Browse repository at this point
Copy the full SHA c74f68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d41acd - Browse repository at this point
Copy the full SHA 7d41acdView commit details -
Fix percentage inversion, update tests (#1848)
Looking through the transformations, I noticed that we were subtracting a percentage that is usually between 0-100 from 1 instead of 100, and so were endind up with some surprising results. Confirmed with lucasmbrown-usds
Configuration menu - View commit details
-
Copy full SHA for b55e667 - Browse repository at this point
Copy the full SHA b55e667View commit details
Commits on Sep 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f36ea7c - Browse repository at this point
Copy the full SHA f36ea7cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.