Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typenames are being unnecessarily added #320

Closed
andyrichardson opened this issue Jun 26, 2019 · 0 comments · Fixed by #321
Closed

Typenames are being unnecessarily added #320

andyrichardson opened this issue Jun 26, 2019 · 0 comments · Fixed by #321
Labels
bug 🐛 Oh no! A bug or unintented behaviour.

Comments

@andyrichardson
Copy link
Contributor

Typenames are added to selections without checking if a typename node is already present.

Example query:

{
  todos {
    id
    text
    complete
    __typename
    __typename
    __typename
  }
  __typename
  __typename
  __typename
}
@andyrichardson andyrichardson added the bug 🐛 Oh no! A bug or unintented behaviour. label Jun 26, 2019
@andyrichardson andyrichardson mentioned this issue Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Oh no! A bug or unintented behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add typename existence check urql-graphql/urql
1 participant
@andyrichardson