Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query component requires client and key in props #219

Closed
capaj opened this issue Apr 3, 2019 · 5 comments
Closed

Query component requires client and key in props #219

capaj opened this issue Apr 3, 2019 · 5 comments
Labels
bug 🐛 Oh no! A bug or unintented behaviour.

Comments

@capaj
Copy link

capaj commented Apr 3, 2019

I am using uql with typescript and I have a problem with

image

none of the examples show the <Query /> component with these two props yet they are required.
Either the typing is wrong or all the examples need amending. I am thinking the former.
@andyrichardson
Copy link
Contributor

Your code looks about right. Can you confirm which version you are currently using?

@andyrichardson andyrichardson added the needs more info ✋ A question or report that needs more info to be addressable label Apr 5, 2019
@capaj
Copy link
Author

capaj commented Apr 5, 2019

Using latest 1.0.4

@andyrichardson andyrichardson mentioned this issue Apr 5, 2019
Merged
@andyrichardson
Copy link
Contributor

Looks like there were a couple of things that caused this. There's a PR to fix the issue.

Would strongly recommend that you look into upgrading react and using the hooks implementation if possible.

@capaj
Copy link
Author

capaj commented Apr 5, 2019

Very fast response! This is exactly the patch I had in mind.Hope it get's merged soon.

@andyrichardson
Copy link
Contributor

I'll pressure @kitten to approve 👿

@andyrichardson andyrichardson added bug 🐛 Oh no! A bug or unintented behaviour. and removed needs more info ✋ A question or report that needs more info to be addressable labels Apr 5, 2019
@kitten kitten mentioned this issue Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Oh no! A bug or unintented behaviour.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@capaj @andyrichardson