Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete install instructions #194

Closed
BrummbQ opened this issue Jun 7, 2018 · 4 comments
Closed

Incomplete install instructions #194

BrummbQ opened this issue Jun 7, 2018 · 4 comments

Comments

@BrummbQ
Copy link

BrummbQ commented Jun 7, 2018

Hello!

Since you added moment as a peer dependency, a user must install moment.js first before using this package, else the build just fails with Cannot find module 'moment'.

I think you should the users about this, maybe even list moment in the npm install command

@urish urish closed this as completed in 578acbf Jun 7, 2018
@urish
Copy link
Owner

urish commented Jun 7, 2018

Thanks! released as 3.0.1

@nohanna
Copy link

nohanna commented Jun 29, 2018

Hey,

I don't know if I am the only one in this case but I've still this error with the 3.0.1 version and have to install moment.js.

Any suggestions?

@BrummbQ
Copy link
Author

BrummbQ commented Jun 29, 2018

yeah, I mean thats the point? You need to install both packages as instructed

@nohanna
Copy link

nohanna commented Jun 29, 2018

Oh ok, thought it was just for system.js users.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants