Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package lacks files from git #130

Closed
royappa opened this issue Mar 16, 2017 · 2 comments
Closed

npm package lacks files from git #130

royappa opened this issue Mar 16, 2017 · 2 comments

Comments

@royappa
Copy link

royappa commented Mar 16, 2017

Description of the Issue and Steps to Reproduce:

Did you search for duplicate issue? [Yes / No]
Yes

Please describe the issue and steps to reproduce, preferably with a code sample / plunker:

I wanted to use the add/subtract functions but they are not available via npm even though the version number and package.json seems to indicate they should be included. Evidence below from my installation. I don't know if the package is incomplete or damaged in any other way, just that these files are missing.

$ npm install --save angular2-moment
$ cd node_modules/angular2-moment
$ egrep 'add|subtract' package.json
    "add.pipe.js",
    "add.pipe.js.map",
    "add.pipe.d.ts",
    "add.pipe.metadata.json",
    "subtract.pipe.js",
    "subtract.pipe.js.map",
    "subtract.pipe.d.ts",
    "subtract.pipe.metadata.json",
$ ls -als add* subtract*
ls: cannot access add*: No such file or directory
ls: cannot access subtract*: No such file or directory
$ fgrep version package.json
  "version": "1.3.0"

Ensure your issue is isolated to angular2-moment. Issues involving third party tools will be closed unless submitted by the tool's author/maintainer.

Environment:

Please answer the following questions:

  • Angular version?
  • TypeScript version?
  • moment version?
  • Are you using moment-timezone?
  • Are you using the angular-cli?
  • Using Rollup/Webpack/System.js/Ionic/similar?
@urish
Copy link
Owner

urish commented Mar 16, 2017

Fixed, released as 1.3.1

@urish urish closed this as completed Mar 16, 2017
@royappa
Copy link
Author

royappa commented Mar 16, 2017

Verified fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants