Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature): Add locale settings #120

Closed
Ledzz opened this issue Jan 11, 2017 · 3 comments
Closed

(feature): Add locale settings #120

Ledzz opened this issue Jan 11, 2017 · 3 comments

Comments

@Ledzz
Copy link

Ledzz commented Jan 11, 2017

I would love to change the locale of moment.js. Maybe it can be done with MomentModule.withConfig({ ... })? I've managed to set locale by importing native moment module, but this means I need to import one excess module (which is already imported).

@urish
Copy link
Owner

urish commented Jan 11, 2017

I believe specifying the locale directly on the moment object should do the trick, see #107 for discussion

@adammartin1981
Copy link

This does work - however if you then change the locale after the pipe has been rendered, it won't update.

I'm thinking about creating a pull request to implement the non-pure (pure:false) version of the pipes so that they change based on the moment locale changes.

@FallenRiteMonk
Copy link
Contributor

If committed a PR which should resolve the problem. #155

@urish urish closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants