Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC721 functions from Ecliptic are exposed #30

Open
Fang- opened this issue May 6, 2019 · 1 comment
Open

ERC721 functions from Ecliptic are exposed #30

Fang- opened this issue May 6, 2019 · 1 comment

Comments

@Fang-
Copy link
Member

Fang- commented May 6, 2019

Arguably, these shouldn't be exposed in azimuth-js. The Ecliptic has its own, custom-fit transfer function (transferPoint), which gives more control over how the transfer actually happens. If you're using azimuth-js, you're already away from standards, and generally better off buying in completely.

When using transferFrom, for example, the reset that happens is implied, whereas calling transferPoint makes it clear that a reset is happening.

Willing to be fought on this.

@ransonhobbes
Copy link
Contributor

Something else to consider: we may want to encourage use of safeTransferFrom over transferFrom or transferPoint. See ransonhobbes/stardust#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants