카테고리 리덕스 세팅 및 페이지에 적용 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/searchBar
… into feature/redux-setting
yjkwon07
reviewed
Feb 16, 2021
yjkwon07
reviewed
Feb 16, 2021
yjkwon07
reviewed
Feb 16, 2021
yjkwon07
reviewed
Feb 16, 2021
yjkwon07
added
enhancement
…urLink-frontend into feature/categoryCard2.0
- reducer state는 아직 사용하지 않아서 정의 안 함
…EV/urLink-frontend into feature/redux-setting
- Header 부분 탭 열기/ 삭제, Search 구현 해야 함
…EV/urLink-frontend into feature/redux-setting
- 기본으로 bottom 영역에 생기도록 스타일 수정
- redux searchFilter 관리 - SearchBar 공통 컴포넌트로 이동 - SearchButton ToggleButton 추가 - RefreshButton 추가 - TabButtonGroup 추가
- reload: 검색어 포함 다시 로드, refresh: 초기 값으로 다시 로드(변수명 정의 변경) - detact로 reload 감지를 할지 결정 - linkRead 할 때, categoryId, 검색 파라미터가 한번에 바뀌지 않음 - 네트워크 불필요한 요청들이 나가게 됨 - takeLatest => debounce로 파라미터 변경 시간을 고려하여 조절 - debounce 1000 => 100으로 변경
- useCallback 추가 및 필요없는 import, 함수 사용 제거
…EV/urLink-frontend into feature/redux-setting
…/urLink-frontend into feature/redux-setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
카테고리 컴포넌트 재구성
=>
CategoryButtonGroup,CategoryHeader,CategoryListItem생성카테고리 api 모듈 생성 및 개선
LinkDropZone 컴포넌트 handleDropOnCardArea 로직 개선
코드 리뷰 적용 (21/03/04 기준)