-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] added pycodestyle checking and ci structure #50
base: master
Are you sure you want to change the base?
Conversation
[Feedback Request] pycodestyle triggers on substantial amount of code. I've already added E501 to the |
@bburns632 Currently? They are presenting themselves as a failed build (see above). It's currently executed before In the future? Depends on how aggressively you want to enforce conventions. I think the easiest thing for maintainers, and the best for consistency across the code base, would be to keep them as errors. Based on the length of the logs from the previous builds, it's probably worth figuring out which ones are taking a stand on (errors) and which PEP8 conventions are less valuable. |
Syntax unit tests are best practice, yes, but IMO most valuable in popular,
high rate of PR projects. I would love for this package to get to a point
where evaluating PRs are a burden and/or there are multiple authors with
different default styles of code, but that is not the case today.
Subsequently, I think it would be most valuable to to get these PEP8 checks
in place (like you have done) but enforce very few syntax constraints (like
1 - 3) at first, especially since the current code does not follow PEP8.
…On Mon, Sep 23, 2019 at 4:05 PM Sam Adams ***@***.***> wrote:
@bburns632 <https://github.com/bburns632> Currently? They are presenting
themselves as a failed build (see above). It's currently executed before
pytest, so don't think it counts as a unit test per se. Definitely more
serious than a warning though.
In the future? Depends on how aggressively you want to enforce
conventions. I think the easiest thing for maintainers, and the best for
consistency across the code base, would be to keep them as errors. Based on
the length of the logs from the previous builds, it's probably worth
figuring out which ones are taking a stand on (errors) and which PEP8
conventions are less valuable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50?email_source=notifications&email_token=AF3FDSZHQ6DQEJJYAVYUQ2LQLEVQDA5CNFSM4IZRIJR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MIO5Q#issuecomment-534284150>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF3FDS35A27OTB3OBRSMYRDQLEVQDANCNFSM4IZRIJRQ>
.
|
Fixes: #46
Added pycodestyle and moved CI components into a .ci folder as suggested by @jameslamb in the provided example.