Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(did-resolver): always include didResolutionMetadata in result #682

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Aug 26, 2021

fixes #681

It looks like the did-key resolver we use does not include a didResolutionMetadata in the result.

I also deduplicated some code in sendDidCommMessage and added some more null guards.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #682 (dde8f44) into next (88264db) will increase coverage by 11.49%.
The diff coverage is 74.51%.

❗ Current head dde8f44 differs from pull request most recent head 35b7852. Consider uploading reports for the commit 35b7852 to get more accurate results

@@             Coverage Diff             @@
##             next     #682       +/-   ##
===========================================
+ Coverage   67.58%   79.07%   +11.49%     
===========================================
  Files          62       78       +16     
  Lines        1530     2361      +831     
  Branches      247      416      +169     
===========================================
+ Hits         1034     1867      +833     
- Misses        400      492       +92     
+ Partials       96        2       -94     

@mirceanis mirceanis merged commit aabddb4 into next Aug 26, 2021
@mirceanis mirceanis deleted the 681-fix-misbehaving-resolver-for-didcomm branch August 26, 2021 14:01
@mirceanis mirceanis mentioned this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packDidCommMessage with did:key recipient fails
1 participant