Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: eth_signTransaction #660

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Fix: eth_signTransaction #660

merged 4 commits into from
Aug 11, 2021

Conversation

simonas-notcat
Copy link
Contributor

Fixes: #641

@mirceanis mirceanis changed the base branch from next to main August 11, 2021 12:51
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #660 (879dc9f) into main (232de66) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files          78       78           
  Lines        2344     2344           
  Branches      409      409           
=======================================
  Hits         1823     1823           
  Misses        519      519           
  Partials        2        2           

@mirceanis mirceanis merged commit d45129e into main Aug 11, 2021
@mirceanis mirceanis deleted the fix/eth-sign-tx branch August 11, 2021 12:58
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, I'll merge it in as a hotfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Veramo CLI fails to add key and raises exception
3 participants