feat: implement didcomm v2 packing/unpacking #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
force-pushed
the
feat/didcomm-v2-packing
branch
from
67e250f to
1e5b276
Compare
awoie
reviewed
Jun 21, 2021
packages/did-comm/src/__tests__/did-comm.action-handler.test.ts
Outdated
Show resolved
Hide resolved
awoie
reviewed
Jun 21, 2021
awoie
reviewed
Jun 21, 2021
Codecov Report
@@ Coverage Diff @@
## next #575 +/- ##
===========================================
+ Coverage 67.58% 77.77% +10.19%
===========================================
Files 62 72 +10
Lines 1530 2227 +697
Branches 247 396 +149
===========================================
+ Hits 1034 1732 +698
- Misses 400 493 +93
+ Partials 96 2 -94 |
mirceanis
force-pushed
the
feat/didcomm-v2-packing
branch
from
5ca3d15 to
46aa1eb
Compare
awoie
reviewed
Jun 23, 2021
packages/core/src/types/IResolver.ts
Outdated
| @@ -59,4 +65,61 @@ export interface IResolver extends IPluginMethodMap { | |||
| * @public | |||
| */ | |||
| resolveDid(args: ResolveDidArgs): Promise<DIDResolutionResult> | |||
|
|
|||
| /** | |||
| * Dereferences a DID URI fragment and return the corresponding DID document entry. | |||
There was a problem hiding this comment.
Suggested change
| * Dereferences a DID URI fragment and return the corresponding DID document entry. | |
| * Dereferences a DID URL fragment and returns the corresponding DID document entry. |
awoie
reviewed
Jun 23, 2021
awoie
reviewed
Jun 23, 2021
awoie
reviewed
Jun 23, 2021
awoie
approved these changes
Jun 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
IDIDComm.packDIDCommMessage()andIDIDComm.unpackDIDCommMessage()for plaintext, signed and encrypted (auth and anon) DIDComm.fixes #558
fixes #559
This also adds a
getDIDComponentByIdmethod to theIResolverplugin, which can be used to get aVerificationMethodor aServiceEndpointobject form a DID document using anid.