fix(kms-local): replace buggy didcomm clone with did jwt implementation #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
changed the title
Codecov Report
@@ Coverage Diff @@
## next #548 +/- ##
==========================================
+ Coverage 67.58% 77.17% +9.58%
==========================================
Files 62 71 +9
Lines 1530 1866 +336
Branches 247 314 +67
==========================================
+ Hits 1034 1440 +406
- Misses 400 424 +24
+ Partials 96 2 -94 |
…rom `did-jwt` fix(kms-local): replace buggy didcomm-js clone with anon encryption from `did-jwt` fixes #538
Please use `@veramo/kms-local` instead
mirceanis
force-pushed
the
538-replace-buggy-didcomm-with-did-jwt-implementation
branch
from
b148385 to
d19879d
Compare
mirceanis
commented
Jun 3, 2021
| @@ -41,7 +41,7 @@ export class KeyManager implements IAgentPlugin { | |||
| keyManagerGet: this.keyManagerGet.bind(this), | |||
| keyManagerDelete: this.keyManagerDelete.bind(this), | |||
| keyManagerImport: this.keyManagerImport.bind(this), | |||
| keyManagerEncryptJWE: this.keyManagerDecryptJWE.bind(this), | |||
There was a problem hiding this comment.
Oooohweee, what a typo!!
This is likely the culprit of #306
mirceanis
deleted the
538-replace-buggy-didcomm-with-did-jwt-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an old bug that was causing incorrect didcomm messaging in veramo.
The
kms-localplugin now uses thedid-jwtimplementation of JWE using the anon [de]encrypter.kms-localplugin can be used in a react-native context.It works fine. Don't forget to add
@ethersproject/shims.libsodium-wrappersdependency and replaces it with@stablelib/*which should make it easier to work with multiple JS environments.kms-local-react-native. Usekms-localinstead.fixes #538
probably also fixes #306