Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable setting headers to DAF DID Comm #239

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

ilanolkies
Copy link
Contributor

Allow to set headers to the HTTPS POST request when using DID Comm action handler

ilanolkies added a commit to rsksmart/rif-identity.js that referenced this pull request Sep 25, 2020
ilanolkies added a commit to rsksmart/rif-identity.js that referenced this pull request Sep 30, 2020
* Add Did Comm action handler with headers feature

Reference: decentralized-identity/veramo#239

* Enable headers when requesting credentials

* Use axsios instead of fetch to handle sending of the message.

Co-authored-by: Jesse Clark <[email protected]>
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you for starting this.
Can you clarify the question of the data type, please?

packages/daf-did-comm/src/action-handler.ts Outdated Show resolved Hide resolved
@mirceanis mirceanis changed the title feat: Enable to set headers to DAF DID Comm feat: Enable setting headers to DAF DID Comm Nov 12, 2020
@mirceanis mirceanis merged commit 03f3dbb into decentralized-identity:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants