-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(did-key-provider): add key import support #1165
feat(did-key-provider): add key import support #1165
Conversation
…eat/key-did-import
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1165 +/- ##
==========================================
+ Coverage 80.25% 85.06% +4.81%
==========================================
Files 118 154 +36
Lines 4056 15738 +11682
Branches 875 1662 +787
==========================================
+ Hits 3255 13387 +10132
- Misses 798 2351 +1553
+ Partials 3 0 -3
... and 61 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Thanks for adding it.
What is being changed
Add the key import functionality to the did-key-provider. Users can import Ed25519, X25519 or Secp256k1 private keys and use them to generate a did:key identifier.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.