Fix react-native migrations on older Android installations #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure PreMigrationKey has all the properties of Key (as used in the createDatabase migration), to ensure that the change column results in a table with all columns, not dropping for instance the privateKeyHex in Sqlite on older RN environments
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #1152 +/- ##
==========================================
+ Coverage 80.25% 85.25% +5.00%
==========================================
Files 118 151 +33
Lines 4056 15418 +11362
Branches 875 1629 +754
==========================================
+ Hits 3255 13145 +9890
- Misses 798 2273 +1475
+ Partials 3 0 -3
... and 58 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mirceanis
approved these changes
Mar 28, 2023
|
@mirceanis Okay we have tested this against multiple Android versions and it seems to be working for all of them now. |
This was referenced Mar 31, 2023
mirceanis
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
In React-Native on older Android APIs (<11) the migrations where failing. That has to do with the 2nd and 3rd migration file. The 2nd migration file wasn't correctly creating new temp tables including privateKeyHex, because it picked up the wrong entity it seems. Probably because the matching logic on the metadata against a list of metadata has a different order in these environments. As a result the 3rd migration also failed. It is now using a name when creating new tables, but using the actual matched table from the matching logic on existing tables.
Unrelated, the TypeORM migrations are failing in production settings where minifying is being used. That has to do with the fact that TypeORM relies on classnames and its timestamp suffix. When minifying this goes away, so I simply added the name property to the migration files.
As the same method was being copied over between migrations, also create 2 helper functions, so that the code is now shared across migrations and can also be used by people extending Veramo, which might have their own migrations.
Still needs more testing before converting this from draft to final PR
What is being changed
A clear description of what this PR brings.
Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.