Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): server await getConfig #1145

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix(cli): server await getConfig #1145

merged 2 commits into from
Mar 15, 2023

Conversation

simonas-notcat
Copy link
Contributor

What issue is this PR fixing

fixes #1144

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

mirceanis
mirceanis approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there's a failure because of babel-jest missing for browser tests (test-react-app package).
Can you take a look at that too, pls?

@mirceanis mirceanis merged commit 2a0aef1 into next Mar 15, 2023
@mirceanis mirceanis deleted the fix/1144-cli-server branch March 15, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI server is broken
2 participants
@simonas-notcat @mirceanis