Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] @veramo/data-store#PrivateKeyStore.listKeys() does not compute public keys properly. #1136

Closed
mirceanis opened this issue Feb 24, 2023 · 0 comments · Fixed by #1137
Closed

[bug] @veramo/data-store#PrivateKeyStore.listKeys() does not compute public keys properly. #1136

mirceanis opened this issue Feb 24, 2023 · 0 comments · Fixed by #1137
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Member

Bug severity
1 - this is not part of the public plugin API and not used internally in relevant code

Describe the bug
@veramo/data-store#PrivateKeyStore.listKeys() does not decrypt the keys using the available SecretBox.
This means that downstream code that uses this (@veramo/kms-local#KeyManagementSystem.listKeys()) shows the wrong public key material for the corresponding keys.

Versions (please complete the following information):

  • Veramo: >=3.0.0 <=5.0.0
@mirceanis mirceanis added the bug Something isn't working label Feb 24, 2023
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(data-store): decrypt keys before listing in `PrivateKeyStore.list…
a66169f 
…Keys()`

fixes #1136
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(data-store-json): decrypt before listing in `PrivateKeyStoreJson.…
21cc43d 
…listKeys()`

fixes #1136
@mirceanis mirceanis mentioned this issue Feb 24, 2023
Merged
5 tasks
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(data-store): decrypt keys before listing in `PrivateKeyStore.list…
0234e83 
…Keys()`

fixes #1136
mirceanis added a commit that referenced this issue Feb 24, 2023
@mirceanis
fix(data-store-json): decrypt before listing in `PrivateKeyStoreJson.…
a0f439c 
…listKeys()`

fixes #1136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: P256 key parity corrections decentralized-identity/veramo
1 participant
@mirceanis