New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] @veramo/key-manager - SES_IMPORT_REJECTED #1090

Closed

luckdev01 opened this issue Dec 28, 2022 · 2 comments · Fixed by #1110

Assignees

Labels

bug

luckdev01 commented Dec 28, 2022

I encountered this issue when using @veramo/key-manager.
[SyntaxError: Possible import expression rejected at :44396. (SES_IMPORT_REJECTED)]

Related issue: https://github.com/endojs/endo/blob/master/packages/ses/error-codes/SES_IMPORT_REJECTED.md

The issue is due to this.

The problem is that the function name is "import".

luckdev01 added the bug label

Contributor

nickreynolds commented Jan 27, 2023

@mirceanis this does seem like it could be causing problems. I propose we just rename this function to importKey. Should we rename the other functions to match?

Member

mirceanis commented Jan 27, 2023

Correct. I'll work on it today so that we can include it in the upcoming 5.0 release

mirceanis self-assigned this

mirceanis added a commit that referenced this issue


          fix(key-manager): rename Abstract[Private]KeyStore methods for SES co…

667ad8b

…mpatibility

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractKeyStore and AbstractPrivateKeyStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(did-manager): rename AbstractDIDStore methods for SES compatibility

690aa38

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractDIDStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(key-manager): rename Abstract[Private]KeyStore methods for SES co…

…mpatibility

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractKeyStore and AbstractPrivateKeyStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(did-manager): rename AbstractDIDStore methods for SES compatibility

97e9e3e

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractDIDStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(key-manager): rename Abstract[Private]KeyStore methods for SES co…

d63c8c4

…mpatibility

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractKeyStore and AbstractPrivateKeyStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(did-manager): rename AbstractDIDStore methods for SES compatibility

6fb20a0

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractDIDStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis mentioned this issue

fix: SES import method rename #1110

Merged

6 tasks

mirceanis added a commit that referenced this issue


          fix(key-manager): rename Abstract[Private]KeyStore methods for SES co…

bae534e

…mpatibility

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractKeyStore and AbstractPrivateKeyStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(did-manager): rename AbstractDIDStore methods for SES compatibility

8ff2c4a

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractDIDStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis closed this as completed in #1110

mirceanis added a commit that referenced this issue


          fix(key-manager): rename Abstract[Private]KeyStore methods for SES co…

91631b6

…mpatibility

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractKeyStore and AbstractPrivateKeyStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis added a commit that referenced this issue


          fix(did-manager): rename AbstractDIDStore methods for SES compatibility

The only problem method name was `import`, but all methods were renamed to maintain consistency in the API.

fixes #1090

BREAKING CHANGE: implementations of AbstractDIDStore need to rename their methods to conform to the new API. Functionality remains the same.

mirceanis mentioned this issue

chore: new major release #1114

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment