-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(credential-eip712): add support for all did methods that use secp256k #1011
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1011 +/- ##
==========================================
- Coverage 80.25% 80.15% -0.10%
==========================================
Files 118 118
Lines 4056 4173 +117
Branches 875 897 +22
==========================================
+ Hits 3255 3345 +90
- Misses 798 825 +27
Partials 3 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that was fast :)
Thanks for contributing this!
There are some methods added that were already present either directly or with functionality already imported from ethersjs. Please check my comments and let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
There is a small conflict that needs to be resolved before being able to merge.
Can you please take care of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the secp256k1
dependency and other unused imports as they are not needed.
More dependencies === more trouble; we try to be very strict with this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic, thank you for the contribution!
What issue is this PR fixing
This PR fixes the issue (Fixes #991 ) with credential-eip712 library, where only did:ethr was supported, while every did method that uses secp256k should've been.
Closes #991
Linking to an issue provides some context and a reason for the PR to be reviewed, as well as simplifying the release
notes and changelogs that get generated automatically. If an issue is linked like this it will be automatically closed
when the PR is merged.
What is being changed
credential-eip712
utils
getEthereumAddress
now generates an address for compressed and uncompressedpublicKeyHex
,publicKeyBase58
andpublicKeyBase64
.Quality
Check all that apply:
yarn
,yarn build
,yarn test
locally.