Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Rename KPAccountCreator class and add comments class and add comments #46

Open
ugoamanoh opened this issue Nov 5, 2018 · 2 comments
Open

Rename KPAccountCreator class and add comments class and add comments #46

ugoamanoh opened this issue Nov 5, 2018 · 2 comments
Labels
documentation Some documentation should be created as a result of this getting fixed. support Code cleanup

Comments

@ugoamanoh
Copy link
Contributor

ugoamanoh commented Nov 5, 2018 •
edited by mirceanis
Loading

The class KPAccountCreator should be renamed to something more intuitive and comments to be added for a better understanding of what the class is doing

Acceptance criteria:

  • KPAccountCreator to be renamed to KeyPairAccountCreator
  • kdoc comment describing high level functionality of class
  • kdoc comment describing AccountCreator interface
  • Existing tests must pass (after rename)
  • breaking change from rename marked in changelog

No new tests needed but they won't be rejected if any are added :)

This is mirroring #161718980 in pivotal
@mirceanis mirceanis added the support Code cleanup label Nov 5, 2018
@mirceanis
Copy link
Contributor

is KeyPairAccountCreator more meaningful?

@ugoamanoh
Copy link
Contributor Author

yes

@mirceanis mirceanis added the documentation Some documentation should be created as a result of this getting fixed. label Nov 5, 2018
@ugoamanoh ugoamanoh changed the title Rename Rename KPAccountCreator class and add comments class and add comments Rename KPAccountCreator class and add comments class and add comments Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Some documentation should be created as a result of this getting fixed. support Code cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirceanis @ugoamanoh