Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the UniversalDID singleton #32

Closed
5 of 6 tasks
mirceanis opened this issue Nov 4, 2019 · 1 comment
Closed
5 of 6 tasks

deprecate the UniversalDID singleton #32

mirceanis opened this issue Nov 4, 2019 · 1 comment
Assignees

Comments

@mirceanis
Copy link
Collaborator

mirceanis commented Nov 4, 2019

Development checklist

  • 1. deprecate the UniversalDID object
  • 2. in the universal-did module, create a DIDResolverImpl internal class with the same functionality as UniversalDID, just not a singleton
  • 3. create builder pattern for DIDResolver that returns a DIDResolverImpl instance
    example usage:
    val resolver : DIDResolver = DIDResolver.Builder
    .addResolver(ethrDidResolver)
    .addResolver(/*...*/)
    .build()
  • 4. remove UniversalDID initialization code from JWTTools constructor.
  • 5. create a module called uport-defaults
    • 5.1 Create a fun DIDResolver.configureDefaultsWithInfura(infuraProjectId : String) : DIDResolver extension method
    • 5.2 This method should call a DIDResolver.Builder that uses the provided infuraProjectId to configure all the common networks and resolvers in a manner similar to the UniversalDID initialization done in the current JWTTools constructor.
    • 5.3 remove now unused dependencies from the jwt module. It should no longer depend on ethr-did, web-did, uport-did
  • 6. Update documentation to reflect new usage patterns
@mirceanis
Copy link
Collaborator Author

This was fixed in #34 except for the last point.
I'll close this and open a new issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants