Set iat timestamp by default instead of nbf
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
========================================
Coverage 96.65% 96.65%
========================================
Files 7 7
Lines 209 209
Branches 51 50 -1
========================================
Hits 202 202
Misses 7 7
Continue to review full report at Codecov.
|
mirceanis
approved these changes
Aug 13, 2019
mirceanis
reviewed
Aug 13, 2019
mirceanis
reviewed
Aug 13, 2019
mi-xu
force-pushed
the
feature/167819821/iat-create
branch
from
3a336c1
to
44bf4f7
Compare
mi-xu
added a commit
that referenced
this pull request
Aug 15, 2019
* refactor: change createJWT to set iat by default instead of nbf * test: add tests for iat behavior in createJWT * feat: do not set iat if value in payload is null * fix: set payload.iat to undefined instead of null to omit from JWT * fix code style for division * fix code style BREAKING CHANGE: expiresIn option passed to createJWT now calculates exp from nbf instead of iat.
mi-xu
added a commit
that referenced
this pull request
Aug 26, 2019
* change iat to nbf * feat: Set `iat` timestamp by default instead of `nbf` (#43) * refactor: change createJWT to set iat by default instead of nbf * test: add tests for iat behavior in createJWT * feat: do not set iat if value in payload is null * fix: set payload.iat to undefined instead of null to omit from JWT * fix code style for division * fix code style BREAKING CHANGE: expiresIn option passed to createJWT now calculates exp from nbf instead of iat. * chore: add release automation configuration (#44) * feat: verifyJWT against nbf if present but use iat if not (#45) * feat: verifyJWT against nbf if present but use iat if not * fix: apply skew in the opposite direction when checking exp * test: make some test inputs more clear * test: use hard coded JWTs to test validFrom teimstamp * style: remove unused constants * feat: upgrade to local did resolver (#48) * feat: upgrade to local did resolver * refactor: export resolver so it can be mocked in tests * wip: refactor tests to remove dependency on uport and nacl did resolvers * test: fix tests to verify pregenerated JWT * test: fix hard coded jwts for validFrom timestamp tests * test: fix remaining * test: add tests for normalizeDID * refactor: upgrade ethr-did-resolver to fix imports * refactor: rename variables and clean up async syntax for tests
localredhead
pushed a commit
that referenced
this pull request
Aug 28, 2019
* change iat to nbf * feat: Set `iat` timestamp by default instead of `nbf` (#43) * refactor: change createJWT to set iat by default instead of nbf * test: add tests for iat behavior in createJWT * feat: do not set iat if value in payload is null * fix: set payload.iat to undefined instead of null to omit from JWT * fix code style for division * fix code style BREAKING CHANGE: expiresIn option passed to createJWT now calculates exp from nbf instead of iat. * chore: add release automation configuration (#44) * feat: verifyJWT against nbf if present but use iat if not (#45) * feat: verifyJWT against nbf if present but use iat if not * fix: apply skew in the opposite direction when checking exp * test: make some test inputs more clear * test: use hard coded JWTs to test validFrom teimstamp * style: remove unused constants * feat: upgrade to local did resolver (#48) * feat: upgrade to local did resolver * refactor: export resolver so it can be mocked in tests * wip: refactor tests to remove dependency on uport and nacl did resolvers * test: fix tests to verify pregenerated JWT * test: fix hard coded jwts for validFrom timestamp tests * test: fix remaining * test: add tests for normalizeDID * refactor: upgrade ethr-did-resolver to fix imports * refactor: rename variables and clean up async syntax for tests
localredhead
pushed a commit
that referenced
this pull request
Sep 6, 2019
* refactor: change createJWT to set iat by default instead of nbf * test: add tests for iat behavior in createJWT * feat: do not set iat if value in payload is null * fix: set payload.iat to undefined instead of null to omit from JWT * fix code style for division * fix code style BREAKING CHANGE: expiresIn option passed to createJWT now calculates exp from nbf instead of iat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes to
createJWTintroduced in #41 and slightly alters the behavior of how some of the arguments are used:createJWTno longer attempts sets thenbfattribute to the current timestamp by defaultcreateJWTonce again sets theiatattribute to the current timestamp by defaultcreateJWTomits theiatattribute if it is passed in asundefinedin thepayloadcreateJWTonly calculates theexpvalue given theexpiresInoption ifnbfis present in thepayloadnbfno longer defaults to the current timestamp is because it's an optional attribute for JWTs, and therefore does not justify causing a breaking change in this library.did-jwt-vcwill provide higher level functions for creating Verifiable Credentials and Presentations which are responsible for defaulting the value ofnbfsince it is a necessary attribute for verification in those contexts.Another slight difference in behavior here is that the
expiresInoption will be ignored if thepayloaddoes not specifynbf. The previous behavior would only function appropriately in the scenario thatnbfwas not passed in as part of thepayloadsince it would always calculateexpfrom the automatically generatednbfeven if a value was assigned explicitly.