Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types definitions #55

Merged
merged 19 commits into from
Nov 15, 2019
Merged

Add types definitions #55

merged 19 commits into from
Nov 15, 2019

Conversation

bautrukevich
Copy link
Contributor

No description provided.

@lxsmnsyc
Copy link

lxsmnsyc commented Nov 8, 2019

I tried logging the onChange property of the Widget component from the CodeSandbox demo: https://codesandbox.io/embed/uploadcarereact-widget-7xpqp?codemirror=1

and according to this:

{"uuid":"9cb5ddad-0607-4469-ab94-2d36ec99d98b","name":"received_545292116247886.jpeg","size":1822,"isStored":true,"isImage":true,"originalImageInfo":{"color_mode":"RGB","orientation":null,"format":"JPEG","sequence":false,"height":126,"width":128,"geo_location":null,"datetime_original":null,"dpi":null},"mimeType":"image/jpeg","originalUrl":"https://ucarecdn.com/9cb5ddad-0607-4469-ab94-2d36ec99d98b/","cdnUrl":"https://ucarecdn.com/9cb5ddad-0607-4469-ab94-2d36ec99d98b/","cdnUrlModifiers":null,"sourceInfo":{"source":"local","file":{}}} 

it shows a different shape or set of keys

@bautrukevich bautrukevich marked this pull request as ready for review November 11, 2019 11:50
types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@jeetiss
Copy link
Contributor

jeetiss commented Nov 12, 2019

@lxsmnsyc we did it, can you help with review?!

types/index.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jeetiss jeetiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏻

types/tsconfig.json Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@lxsmnsyc
Copy link

I checked the file, may I ask why does it need the JQuery library?

@bautrukevich
Copy link
Contributor Author

@lxsmnsyc You don't need to use jQuery : ) But the current version of uploadcare-widget has jQuery underhood. In the future, we want to remove them and we will remove them.

@bautrukevich
Copy link
Contributor Author

I use only jQuery typings here

@jeetiss jeetiss merged commit 99aa82c into master Nov 15, 2019
@jeetiss jeetiss deleted the feature/types branch November 15, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants