Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onDialogClose onDialogOpen onTabChange callbacks #186

Merged
merged 3 commits into from
Jul 27, 2020
Merged

feat: add onDialogClose onDialogOpen onTabChange callbacks #186

merged 3 commits into from
Jul 27, 2020

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Jul 23, 2020 •
edited
Loading

Description

Checklist

@jeetiss jeetiss self-assigned this Jul 23, 2020
@rsedykh rsedykh requested a review from michaos1 July 23, 2020 14:46
@rsedykh
Copy link
Member

rsedykh commented Jul 23, 2020

@michaos1 глянь пож ридми (https://github.com/uploadcare/react-widget/pull/186/files). Вроде все корректно. Заодно в целом можешь ридми глянуть — это популярная либа.

@jeetiss jeetiss merged commit 6822c22 into master Jul 27, 2020
@jeetiss jeetiss deleted the feat-callbacks branch July 27, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nd0ut nd0ut nd0ut approved these changes

@FilippovAM FilippovAM Awaiting requested review from FilippovAM

@rsedykh rsedykh Awaiting requested review from rsedykh

@michaos1 michaos1 Awaiting requested review from michaos1

Assignees

@jeetiss jeetiss

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeetiss @rsedykh @nd0ut