fix(svg-sprite): unneeded icons leak to the uc-basic sprite

[nd0ut]

Description

Checklist

• Tests (if applicable)
• Documentation (if applicable)
• Changelog stub (or use conventional commit messages)

Summary by CodeRabbit

• New Features

  • Updated SVG sprite definitions with a complete set of icon symbols, enhancing visual elements across the application.

• Bug Fixes

  • Improved the instantiation logic for SVG sprite generation, ensuring that each icon set is processed independently.

[coderabbitai]

Walkthrough

The pull request includes changes to two files: svg-sprite.js and build-svg-sprite.js. The svg-sprite.js file has undergone a complete replacement of its SVG string, updating the symbol definitions for various icons while maintaining the original structure. In build-svg-sprite.js, the scope of the spriter variable has been modified to be declared within a loop, ensuring a new instance of SVGSpriter is created for each item in the DATA array.

Changes

File Path	Change Summary
blocks/themes/uc-basic/svg-sprite.js	Entire SVG string replaced with a new set of symbol definitions for various icons.
build-svg-sprite.js	spriter variable scope changed to be declared inside the DATA.forEach loop for each icon set.

Poem

🐇 In a world of icons bright,
A sprite was born to bring delight.
Each symbol shines, a new design,
With spriters working, all in line.
Hopping through the code with glee,
A joyful change for all to see! 🌟

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

build-svg-sprite.js (1)

Line range hint 1-80: Optional enhancements for consideration

While the main issue has been effectively addressed, here are some optional enhancements that could further improve the code:

1. Error handling: Consider implementing more robust error handling instead of throwing errors, which might abruptly terminate the process. This could involve logging errors and continuing with the next item in the DATA array.

2. Asynchronous operations: The code currently uses callbacks. Consider refactoring to use promises or async/await for improved readability and easier error handling.

3. Logging: While the current logging is informative, you might want to enhance it to provide more structured output, possibly including timestamps or grouping log messages by each DATA item being processed.

These suggestions are not critical for the current fix but could be considered for future improvements to enhance the overall robustness and maintainability of the code.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e15c63e and 2600771.

📒 Files selected for processing (2)

• blocks/themes/uc-basic/svg-sprite.js (1 hunks)
• build-svg-sprite.js (1 hunks)

🔇 Additional comments (2)

build-svg-sprite.js (1)

52-53: Excellent fix for isolating sprite generation!

Moving the spriter declaration inside the DATA.forEach loop is a great solution to prevent unneeded icons from leaking into different sprites. This change ensures that each iteration of the loop has its own independent SVGSpriter instance, effectively isolating the sprite generation for each input-output pair.

This modification directly addresses the issue mentioned in the PR title and prevents any potential cross-contamination between different sprite generations.

blocks/themes/uc-basic/svg-sprite.js (1)

1-1: ⚠️ Potential issue

Verify that only necessary icons are included in the SVG sprite

The SVG sprite includes a comprehensive list of icons, such as uc-icon-dropbox, uc-icon-facebook, uc-icon-instagram, uc-icon-gdrive, and others. Given that the PR aims to fix unneeded icons leaking into the uc-basic sprite, please ensure that only the icons required for the uc-basic theme are included. Including unnecessary icons may increase the bundle size and affect performance.

Run the following script to identify unused icons in the codebase:

This script utilizes rg (ripgrep) to search for occurrences of each icon in the codebase. Review the output to determine which icons are unused and can be removed from the SVG sprite.