Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WCAG AAA contrast and high-contrast theme #739

Merged
merged 20 commits into from
Sep 19, 2024

Conversation

malgojaviro
Copy link
Contributor

@malgojaviro malgojaviro commented Sep 16, 2024

  • colors were tweaked to comply with WCAG
  • added high-contrast class uc-contrast

Summary by CodeRabbit

  • New Features

    • Enhanced visual styles for UI components in the Cloud Image Editor, including updated button states and improved visibility for sliders and progress bars.
    • Introduced a contrast mode for better accessibility across various components.
  • Bug Fixes

    • Removed pre-commit checks, which may allow code quality issues to be introduced.
  • Style

    • Added new styles for modal dialogs and buttons to improve visual distinction and accessibility.
    • Adjusted color palette to a darker theme for improved contrast.
  • Chores

    • Cleaned up unnecessary pre-commit scripts from the Git workflow.

Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Walkthrough

The pull request introduces multiple changes across various files, primarily focusing on CSS modifications to enhance the visual styling and accessibility of the Cloud Image Editor and associated components. Key updates include the removal of a pre-commit hook script, adjustments to opacity, color variables, and the introduction of new styles for UI elements. These changes aim to improve user interaction and visual consistency throughout the application.

Changes

File Path Change Summary
.husky/pre-commit Removed the pre-commit hook script that enforced lint-staged and TypeScript compilation checks during commits.
blocks/CloudImageEditor/src/css/common.css Enhanced UI component styling with changes to border-radius, color variables for buttons, and opacity settings for the slider.
blocks/CloudImageEditor/src/elements/slider/SliderUi.js Modified opacity of the _zeroDotEl element based on slider value to improve visibility.
blocks/DropArea/drop-area.css Updated styling for the drop area component, focusing on text and icon colors during active drag states.
blocks/FileItem/file-item.css Increased opacity of the .uc-progress-bar in uc-file-item for better visibility, especially when .uc-contrast is applied.
blocks/Modal/modal.css Introduced an outline style for modal dialogs within elements that have the uc-contrast class.
blocks/SourceBtn/source-btn.css Added new hover styles for buttons and icons in uc-source-btn when in a uc-contrast parent.
blocks/themes/uc-basic/common.css Added a border style for secondary buttons in contrast mode.
blocks/themes/uc-basic/theme.css Adjusted color definitions for UI elements, introducing a darker color palette and new color variables for the .uc-contrast class.
solutions/file-uploader/minimal/index.css Added a new style rule for elements within a specific context in the file uploader component.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Git
    participant Lint
    participant TypeScript

    User->>Git: Commits changes
    Git->>Lint: Run lint-staged
    Git->>TypeScript: Run npm run tsc
    Lint-->>Git: Lint results
    TypeScript-->>Git: Compilation results
    Git-->>User: Commit success or failure
Loading

🐰 In the meadow where bunnies play,
New styles and colors brighten the day.
With borders and buttons, all fresh and neat,
Our UI now dances, oh what a treat!
So hop along, let’s celebrate this cheer,
For changes have come, bringing joy near! 🌼✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7af41ba and 14ad611.

Files selected for processing (1)
  • blocks/CloudImageEditor/src/css/common.css (6 hunks)
Files skipped from review as they are similar to previous changes (1)
  • blocks/CloudImageEditor/src/css/common.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@malgojaviro malgojaviro changed the title WCAG AAA contrast and high contrast theme WCAG AAA contrast and high-contrast theme Sep 16, 2024
@egordidenko egordidenko changed the title WCAG AAA contrast and high-contrast theme feat: WCAG AAA contrast and high-contrast theme Sep 19, 2024
@egordidenko egordidenko merged commit 82c29e1 into main Sep 19, 2024
1 check passed
@egordidenko egordidenko deleted the feat/high-contrast-theme branch September 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants