Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "No secrets committed to Git" check with Git hooks? #554

Open
karlhorky opened this issue Jul 11, 2024 · 0 comments
Open

Replace "No secrets committed to Git" check with Git hooks? #554

karlhorky opened this issue Jul 11, 2024 · 0 comments

Comments

@karlhorky
Copy link
Member

karlhorky commented Jul 11, 2024

Instead of checking for secrets after the fact with Preflight, we could instead install a pre-commit Git hook that will check for them, as suggested in this tweet:

The only pre-commit hook you should have is one scanning commits for secrets and API keys.

We could add this with the scaffolder / starter command, which the install script in eslint-config-upleveled should turn into:

@karlhorky karlhorky changed the title Replace secrets check with Git hooks? Replace "No secrets committed to Git" check with Git hooks? Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant