Skip to content

add install-tester workflow #517

add install-tester workflow

add install-tester workflow #517

GitHub Actions / clippy succeeded Oct 25, 2024

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511ee 2024-10-15)

Annotations

Check warning on line 17 in src/urls.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual check for common ascii range

warning: manual check for common ascii range
  --> src/urls.rs:17:9
   |
17 |     if !matches!(first_char, b'a'..=b'z' | b'A'..=b'Z') {
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `first_char.is_ascii_alphabetic()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
   = note: `#[warn(clippy::manual_is_ascii_check)]` on by default

Check warning on line 97 in src/collector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/collector.rs:97:54
   |
97 |         let mut href = BumpString::from_str_in(path, &arena);
   |                                                      ^^^^^^ help: change this to: `arena`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 93 in src/collector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
  --> src/collector.rs:89:24
   |
89 |           let qs_start = used_link
   |  ________________________^
90 | |             .href
91 | |             .0
92 | |             .find(&['?', '#'][..])
93 | |             .unwrap_or_else(|| used_link.href.0.len());
   | |______________________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
   = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `unwrap_or` instead
   |
93 |             .unwrap_or(used_link.href.0.len());
   |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 85 in src/collector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/collector.rs:85:29
   |
85 |         if is_external_link(&used_link.href.0.as_bytes()) {
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `used_link.href.0.as_bytes()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 72 in src/collector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
  --> src/collector.rs:72:62
   |
72 |                 LinkState::Undefined(links2) => links.extend(links2.into_iter()),
   |                                                              ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `links2`
   |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
  --> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/iter/traits/collect.rs:450:18
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default