Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More, better type tests #14

Closed
samhh opened this issue Sep 13, 2021 · 2 comments · Fixed by #18 or #19
Closed

More, better type tests #14

samhh opened this issue Sep 13, 2021 · 2 comments · Fixed by #18 or #19

Comments

@samhh
Copy link
Member

samhh commented Sep 13, 2021

A lot of this library's value is in its behaviour at the type-level, this should be tested! #12 is a good candidate.

@unsplash/web Any experience here?
@OliverJAsh
Copy link
Member

@unsplash/web Any experience here?

Yup, see the type-tests folder in the web repo and these docs: https://github.com/unsplash/unsplash-web/blob/master/type-tests/README.md

@samhh samhh mentioned this issue Sep 14, 2021
Merged
@samhh samhh linked a pull request Sep 14, 2021 that will close this issue
Fix constructor distributing over value union #18
Merged
@samhh samhh closed this as completed in #18 Sep 14, 2021
@samhh
Copy link
Member Author

samhh commented Sep 14, 2021

#18 (comment)

@samhh samhh reopened this Sep 14, 2021
@samhh samhh changed the title Type tests More, better type tests Sep 14, 2021
@samhh samhh mentioned this issue Sep 14, 2021
Merged
@samhh samhh closed this as completed in #19 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix constructor distributing over value union unsplash/sum-types
Add matchW unsplash/sum-types
2 participants
@OliverJAsh @samhh