Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version #15

Closed
skoestler opened this issue May 10, 2018 · 4 comments
Closed

Publish new version #15

skoestler opened this issue May 10, 2018 · 4 comments

Comments

@skoestler
Copy link

There was recently a security fix in a downstream dependency (unshiftio/querystringify#19) and it looks like the dependencies of this module have been updated accordingly but a new version has not yet been published.

I apologize if I am missing something here, but are you planning on publishing a new version of this library with the updated dependencies?

@lpinca
Copy link
Member

lpinca commented May 10, 2018

AFAIK there is actually no harm also with the current version of querystringify. Properties inherited by Object.prototype can be safely overridden and setting __proto__ to a string has no effect. The only problem is if the user expects the inherited properties to not be overridden which doesn't make sense in this lib.

That said a new release doesn't hurt.

cc: @3rd-Eden

@jdx
Copy link

jdx commented May 15, 2018

👍 this shows up in snyk as a high severity vulnerability so it would be nice to have this bumped rather than ignore the vuln in snyk

@3rd-Eden
Copy link
Member

I'm the author of the fix, as well as the reporter to snyk, this module is not affected by it. Generation of an origin string does not require access to querystring params if any shape or form. The only way this module would have been vulnerable is when:

https://github.com/unshiftio/original/blob/master/index.js#L13

sets the second argument to true to enable querystring parsing.

@3rd-Eden
Copy link
Member

1.0.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants