Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): would it be possible to upgrade this to Angular 4.x.x? #2

Closed
GiuseppePiscopo opened this issue May 10, 2017 · 2 comments

Comments

@GiuseppePiscopo
Copy link

GiuseppePiscopo commented May 10, 2017

In my team we're trying to put together a working AOT build with angular 4, @ngtools/webpack (not full angular-cli) and lazy loaded modules. Mini repo is available here.

Current version excludes JiT-related entry points and uses AoT entry points. Build goes fine, but at runtime we see the dreaded Error: Cannot find module '../private/module.ngfactory'. when trying to browse to lazy loaded area.

Locally we also tried doing the opposite (as you do in this repo): exclude AoT-related stuff and use JiT entry points. Same as before: build ok, error at runtime. We also tried adding "baseUrl": "." to tsconfig, but it made no difference.

In both cases, as noted on other angular-cli issues (e.g. 2452), in build output folder we see 0-bundle.js.map, but not 0-bundle.js.

Have you tried upgrading this project to angular 4.1.1, @ngtools/webpack 1.3.1, webpack 2.2.1 (or newer), typescript 2.2.1 (or newer)? Thanks

@unsafecode
Copy link
Owner

@GiuseppePiscopo I'll try to find some time and do all the fixing.

@IAMtheIAM
Copy link
Contributor

IAMtheIAM commented Aug 9, 2017

Yes would you make this update to latest?

Update: Actually I got it working. Only a few changed needed. PR submitted
I also added the missing '/lazy/lazy-feature' route

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants