Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to import the types from the dirs #544

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Nov 19, 2024

Description

support to import the types from the dirs

Linked Issues

close #530

Additional context

Copy link

stackblitz bot commented Nov 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu
Copy link
Member

antfu commented Nov 20, 2024

Is there a case where you only want to auto import types for certain dirs but not the others? Maybe we could simply have another top-level config to toggle it for all dirs?

@noootwo
Copy link
Contributor Author

noootwo commented Nov 20, 2024

Is there a case where you only want to auto import types for certain dirs but not the others? Maybe we could simply have another top-level config to toggle it for all dirs?

You're right, I will add it.

@noootwo
Copy link
Contributor Author

noootwo commented Nov 20, 2024

Is there a case where you only want to auto import types for certain dirs but not the others? Maybe we could simply have another top-level config to toggle it for all dirs?

Ready to be reviewed

@noootwo
Copy link
Contributor Author

noootwo commented Nov 27, 2024

Is there a case where you only want to auto import types for certain dirs but not the others? Maybe we could simply have another top-level config to toggle it for all dirs?

@antfu Do we need to add this new feature to the unimport? If so, it seems that I need to implement the logic there, and it would be better to only make logic calls here.

@antfu
Copy link
Member

antfu commented Nov 27, 2024

Oh yeah, let's do it in unimport then

Copy link

socket-security bot commented Nov 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 18.1 kB types

View full report↗︎

Copy link

socket-security bot commented Nov 29, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@noootwo
Copy link
Contributor Author

noootwo commented Nov 29, 2024

Oh yeah, let's do it in unimport then

@antfu Ready for review

@antfu antfu merged commit 902416f into unplugin:main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to reflect auto importing types from custom dir
2 participants