Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support CommunityToolkit.Mvvm in two way x:Bind #11854

Merged
merged 9 commits into from
Apr 26, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #11644

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Mar 30, 2023
@jeromelaban jeromelaban merged commit b88d874 into unoplatform:master Apr 26, 2023
@Youssef1313 Youssef1313 deleted the mvvm-support branch April 26, 2023 17:07
@dr1rrb
Copy link
Member

dr1rrb commented Apr 27, 2023

We need to reduce the length of the filename / path or this PR, they are forcing us to use incredibly short path to pull Uno's repo.

@Youssef1313
Copy link
Member Author

@dr1rrb Which file is causing the issue?

@dr1rrb
Copy link
Member

dr1rrb commented Apr 28, 2023

@dr1rrb Which file is causing the issue?

@Youssef1313 I would say all the files in the TestOutput folder have very long file path, and in my case I've 3 files that have too long filename. For instance https://github.com/unoplatform/uno/blob/master/src/SourceGenerators/Uno.UI.SourceGenerators.netcore.Tests/XamlCodeGeneratorTests/TestOutput/When_Grid_Uses_New_Assigned_ContentProperty_Syntax/XamlCodeGenerator_Grid_Uses_New_Assigned_ContentProperty_Syntax_9f853e56098ff21d39f15479035509ef.cs is 244 char long (relative to repo root) which breaks on windows as soon as you are checking out the repo in a more than 11 char long path dir (even with long file path enabled).

I'm going to change the name of the tests to reduce the length of the generated filenames.

GitHub
Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - uno/XamlCodeGenerator_Grid_Uses_New_Assigned_ContentProperty_Syntax_9f853e56098ff21d3...

@Youssef1313
Copy link
Member Author

@dr1rrb I have no idea why it's not working with long path enabled. On my machine, I have the repo at C:\Users\PC\Desktop\ which is more than 11 characters and I didn't see issues.

But it should be okay to rename the tests. I'm even interested to find a way to remove the hash from the file name, but that's another thing.

@dr1rrb
Copy link
Member

dr1rrb commented Apr 28, 2023

@Youssef1313

Jérôme pointed me that there is an option in .gitconfig to enable long filename

[core]
    longpaths = true

Will still change the test name to improve first experience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommunityToolkit.Mvvm source generators don't seem to work with Uno XAML parser
4 participants