-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support CommunityToolkit.Mvvm in two way x:Bind #11854
Conversation
99901ce
to
c56f876
Compare
.../When_ObservableProperty_AttributeDoesNotExists/MainPage_d6cd66944958ced0c513e0a04797b51d.cs
Outdated
Show resolved
Hide resolved
.../When_ObservableProperty_AttributeDoesNotExists/MainPage_d6cd66944958ced0c513e0a04797b51d.cs
Outdated
Show resolved
Hide resolved
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Outdated
Show resolved
Hide resolved
28d77c1
to
a74c853
Compare
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs
Outdated
Show resolved
Hide resolved
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs
Outdated
Show resolved
Hide resolved
284f2a4
to
be1b2af
Compare
We need to reduce the length of the filename / path or this PR, they are forcing us to use incredibly short path to pull Uno's repo. |
@dr1rrb Which file is causing the issue? |
@Youssef1313 I would say all the files in the TestOutput folder have very long file path, and in my case I've 3 files that have too long filename. For instance https://github.com/unoplatform/uno/blob/master/src/SourceGenerators/Uno.UI.SourceGenerators.netcore.Tests/XamlCodeGeneratorTests/TestOutput/When_Grid_Uses_New_Assigned_ContentProperty_Syntax/XamlCodeGenerator_Grid_Uses_New_Assigned_ContentProperty_Syntax_9f853e56098ff21d39f15479035509ef.cs is 244 char long (relative to repo root) which breaks on windows as soon as you are checking out the repo in a more than 11 char long path dir (even with long file path enabled). I'm going to change the name of the tests to reduce the length of the generated filenames.
|
@dr1rrb I have no idea why it's not working with long path enabled. On my machine, I have the repo at But it should be okay to rename the tests. I'm even interested to find a way to remove the hash from the file name, but that's another thing. |
Jérôme pointed me that there is an option in
Will still change the test name to improve first experience :) |
GitHub Issue (If applicable): closes #11644
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):