Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lazy for instance creation on sensor classes #19274

Open
nickodei opened this issue Jan 18, 2025 · 1 comment · May be fixed by #19275
Open

Use Lazy for instance creation on sensor classes #19274

nickodei opened this issue Jan 18, 2025 · 1 comment · May be fixed by #19275
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@nickodei
Copy link
Contributor

What would you like to be added

Use the Lazy approach like in the LightSensor.cs class for initialization. Therefore the _initializationAttempted boolean as well as the sync object can be removed. This also unifies the sensor classes to have a similar and simpler implementation.

Note: this issue #19131 startet the refactoring to unify the sensor classes with the StartStopTypedEventHandler.

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@nickodei nickodei added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Jan 18, 2025
@nickodei
Copy link
Contributor Author

I will create a PR later on

@nickodei nickodei linked a pull request Jan 18, 2025 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Use static Lazy instance for all sensors nickodei/uno
1 participant
@nickodei