Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(unlock-js): Graphservice params #15393

Merged
merged 17 commits into from
Jan 23, 2025
Merged

refactor(unlock-js): Graphservice params #15393

merged 17 commits into from
Jan 23, 2025

Conversation

julien51
Copy link
Member

Description

Changing the constructor for GraphService so we can pass params down to the GraphRequest client!

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jan 23, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Jan 23, 2025 4:24pm
unlock-storybook ⬜️ Ignored (Inspect) Jan 23, 2025 4:24pm

@julien51 julien51 requested a review from 0xTxbi January 23, 2025 16:25
@julien51 julien51 mentioned this pull request Jan 23, 2025
Open
6 tasks
@julien51 julien51 changed the title Graphservice params refactor(unlock-js): Graphservice params Jan 23, 2025
@julien51 julien51 requested a review from clemsos January 23, 2025 16:42
@julien51 julien51 merged commit 5a29245 into master Jan 23, 2025
15 checks passed
@julien51 julien51 deleted the graphservice-params branch January 23, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTxbi 0xTxbi 0xTxbi approved these changes

@clemsos clemsos Awaiting requested review from clemsos

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien51 @0xTxbi