Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback / Discord buttons are not available on mobile nav #2171

Closed
3 tasks done
harshsbhat opened this issue Oct 4, 2024 · 14 comments · Fixed by #2180
Closed
3 tasks done

Feedback / Discord buttons are not available on mobile nav #2171

harshsbhat opened this issue Oct 4, 2024 · 14 comments · Fixed by #2180

Comments

@harshsbhat
Copy link
Contributor

Preliminary Checks

Is your feature request related to a problem? Please describe.

Unkey recently added Feedback / Discord in the vertical nav. These options are not there on the mobile navbar

image

Describe the solution

For users joining from mobile, having this on the mobile nav can help them quickly send feedback from the phone instead of logging in to their laptop and then sending some feedback

Describe alternatives you have considered (if any)

No response

Additional context

No response

@harshsbhat harshsbhat added Feature New feature or request Needs Approval Needs approval from Unkey labels Oct 4, 2024
Copy link

linear bot commented Oct 4, 2024

@chronark
Copy link
Collaborator

chronark commented Oct 4, 2024

We need to overhaul the entire mobile nav
All of the links, that are in the desktop version should be here and we should deduplicate the logic.
Right now both desktop and mobile navbar have their own list of items, but it should really be one list of items that gets passed to both components.

@chronark
Copy link
Collaborator

chronark commented Oct 4, 2024

/award 150 points

Copy link

oss-gg bot commented Oct 4, 2024

Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat

@pragyananda
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 4, 2024

Assigned to @pragyananda! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@AkshayBandi027
Copy link
Contributor

unkey-sidebar.mp4

Hey @chronark! ,

  • extract the workspaceNavigation array into separate file that can reused across the desktop and mobile sidebar.
  • Updated Components: I updated the MobileSidebar and DesktopSidebar components to use the new workspace navigation array.
  • Also added resources section with feedback component

@pragyananda
Copy link
Contributor

pragyananda commented Oct 4, 2024

hey @AkshayBandi027
this issue was assigned to me and
if you work on this then you should put a comment I am working on this.
now also I finished this issue. then what do I do?

@chronark
Copy link
Collaborator

chronark commented Oct 4, 2024

@pragyananda is right

@AkshayBandi027 please be careful you don't start work on an issue that is already assigned.


In this case the PR is pretty good and I'm inclined to accept it. If it happens again we'll need to reject it unfortunately.

@pragyananda can you create a new dummy issue, then I'll award you points anyways. I just need an issue where you are the creator to do that.

@pragyananda
Copy link
Contributor

Ok, thanks for this @chronark, and I'll create an issue and update you soon.

@pragyananda
Copy link
Contributor

hello @chronark I have recently created an issue #2207 you can see it.

Copy link

oss-gg bot commented Oct 6, 2024

@pragyananda, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

2 similar comments
Copy link

oss-gg bot commented Oct 8, 2024

@pragyananda, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 10, 2024

@pragyananda, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants