Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args.suffix is ​​undefined when esbuild's onTransform hook is triggered #427

Closed
KID-joker opened this issue Oct 15, 2024 · 4 comments
Closed

Comments

@KID-joker
Copy link

KID-joker commented Oct 15, 2024

Environment

[email protected]

Reproduction

repo

And add any unplugin-related plugins.

Describe the bug

image

image

Additional context

No response

Logs

No response

@KID-joker KID-joker added the bug Something isn't working label Oct 15, 2024
@sxzz
Copy link
Member

sxzz commented Dec 3, 2024

Please provide a minimal reproduction. Thanks.

Why reproduction is required

@sxzz sxzz removed the bug Something isn't working label Dec 3, 2024
@KID-joker
Copy link
Author

Please provide a minimal reproduction. Thanks.

Why reproduction is required

Step 1, download super-dev;
Step 2, install unplugin-auto-import and use it;
Step 3, npm run prod;

Then in 049f99c, we can find that esbuild only provides args.suffix from v0.14.3. The esbuild version used in super-dev is v0.12.24.

@sxzz
Copy link
Member

sxzz commented Dec 3, 2024

I guess you can try to upgrade esbuild version, and the issue will be fixed, right?

@KID-joker
Copy link
Author

Yes, we can upgrade the esbuild version to fix it, but should there be a compatibility fix at L216?

@sxzz sxzz closed this as completed in 35c78d2 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants