Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esbuild emitFile should mkdir subdirectories too #362

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

edemaine
Copy link
Contributor

@edemaine edemaine commented Feb 21, 2024

πŸ”— Linked issue

n/a

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When calling this.emitFile({fileName: 'subdir/foo.d.ts', source, type: 'asset'}), Rollup recursively makes the directory dist/subdir if necessary.

But unplugin's esbuild plugin does not; currently, it just makes the directory dist (where dist is the outdir option). If dist/subdir doesn't exit, the emit crashes.

This small PR changes the esbuild emitFile mkdir call to apply to the full directory (dist/subdir in the example, instead of dist).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@antfu antfu merged commit b73e16a into unjs:main Feb 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants