-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add writeBundle
hook
#179
Conversation
Edit: Nevermind, was just a flake 🤷 |
README.md
Outdated
@@ -27,6 +27,7 @@ Currently supports: | |||
| [`transform`](https://rollupjs.org/guide/en/#transformers) | ✅ | ✅ | ✅ | ✅ | ✅ <sup>3</sup> | | |||
| [`watchChange`](https://rollupjs.org/guide/en/#watchchange) | ✅ | ✅ | ✅ | ✅ | ✅ | | |||
| [`buildEnd`](https://rollupjs.org/guide/en/#buildend) | ✅ | ✅ | ✅ | ✅ | ✅ | | |||
| [`writeBundle`](https://rollupjs.org/guide/en/#writebundle) | ✅ | ✅ | ✅ | ✅ | ✅ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to have a note saying this hook does not pass any arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I added a note in d1f9fd0.
Btw feel free to make any edits to this PR as you see fit!
This PR adds the most basic form of the
writeBundle
hook.The reason for having it even in that form is that the
buildEnd
hook is called before any files have been written to disk and the addedwriteBundle
hook could be used to have plugin code run after bundles have been written.Also adds some tests to verify that the hook has run after assets have been written to disk.