Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isEntry flag to resolveId hook #138

Merged
merged 4 commits into from
Jul 12, 2022
Merged

feat: add isEntry flag to resolveId hook #138

merged 4 commits into from
Jul 12, 2022

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jul 10, 2022

This PR adds the isEntry flag of rollup's resolveId hook to all of unplugin's supported tools.

  • I "cleaned up" the webpack integration a bit. It didn't get a lot cleaner but the TS type inference got a bit better.
  • Added a unit test stup for the resolveId hook. We could use similar setups to test the other hooks.

@antfu
Copy link
Member

antfu commented Jul 12, 2022 •
edited
Loading

Thanks! But seems it fails on Windows

@lforst
Copy link
Contributor Author

lforst commented Jul 12, 2022 •
edited
Loading

@antfu Hi, I think I know what the culprit was. The tests only checked for unix paths. May I ask you to run the workflow again? Thanks!

@lforst
Copy link
Contributor Author

lforst commented Jul 12, 2022

K got it to work :P

@antfu antfu changed the title feat: Add isEntry flag to resolveId hook feat: add isEntry flag to resolveId hook Jul 12, 2022
@antfu antfu merged commit 3b082ed into unjs:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @antfu