Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: withHttp, withHttps, withoutProtocol, withProtocol #48

Merged
merged 2 commits into from
Mar 16, 2022
Merged

feat: withHttp, withHttps, withoutProtocol, withProtocol #48

merged 2 commits into from
Mar 16, 2022

Conversation

divine
Copy link
Contributor

@divine divine commented Mar 16, 2022

Closes #47

pi0
pi0 reviewed Mar 16, 2022
View reviewed changes
src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
divine
divine commented Mar 16, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
pi0
pi0 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@pi0 pi0 merged commit f8ee0c0 into unjs:main Mar 16, 2022
@divine divine deleted the new-features branch March 16, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: withHttps, withHttp, withoutProtocol
2 participants
@divine @pi0