Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rewrite with URL ponyfill #4

Merged
merged 11 commits into from
Dec 15, 2020
Merged

feat!: rewrite with URL ponyfill #4

merged 11 commits into from
Dec 15, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 13, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #4 (301b196) into main (aad752a) will decrease coverage by 11.11%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##              main       #4       +/-   ##
============================================
- Coverage   100.00%   88.88%   -11.12%     
============================================
  Files            1        5        +4     
  Lines           47      144       +97     
  Branches        14       38       +24     
============================================
+ Hits            47      128       +81     
- Misses           0       16       +16     
Impacted Files Coverage Δ
src/ufo.ts 77.41% <77.41%> (ø)
src/parse.ts 93.33% <93.33%> (ø)
src/encoding.ts 97.22% <97.22%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad752a...301b196. Read the comment docs.

@pi0 pi0 changed the title feat: rewrite with UFO class feat: rewrite as ponyfill Dec 13, 2020
test/join.test.ts Outdated Show resolved Hide resolved
src/ufo.ts Outdated Show resolved Hide resolved
src/ufo.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
src/parse.ts Outdated Show resolved Hide resolved
@pi0 pi0 marked this pull request as ready for review December 15, 2020 23:12
@pi0 pi0 changed the title feat: rewrite as ponyfill feat: rewrite with URL ponyfill Dec 15, 2020
@pi0 pi0 changed the title feat: rewrite with URL ponyfill feat!: rewrite with URL ponyfill Dec 15, 2020
@pi0 pi0 merged commit 3809d28 into main Dec 15, 2020
@pi0 pi0 deleted the rewrite branch December 15, 2020 23:13
@pi0
Copy link
Member Author

pi0 commented Dec 15, 2020

(updating docs later because to release faster)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants