feat: support automatic json body for post requests #7

danielroe · 2021-02-18T19:45:38Z

closes #4

src/fetch.ts

* test for pure object proto * avoid try/catch * don't add duplicate header

codecov-io · 2021-02-18T21:03:38Z

Codecov Report

Merging #7 (600a59f) into main (4ab88c2) will increase coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   97.61%   98.27%   +0.65%     
==========================================
  Files           4        4              
  Lines          42       58      +16     
  Branches        8       14       +6     
==========================================
+ Hits           41       57      +16     
  Misses          1        1

Impacted Files	Coverage Δ
src/fetch.ts	`97.22% <100.00%> (+2.22%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab88c2...600a59f. Read the comment docs.

src/fetch.ts

pi0 · 2021-02-18T21:35:38Z

src/fetch.ts

+  } else if ('set' in options.headers) {
+    ;(options.headers as Headers).set(key, value)
+  } else {
+    const existingHeader = Object.keys(options.headers).find(header => header.toLowerCase() === key)


By early returning on set in case, we can dedup this line

not quite sure how to dedupe it - though it feels very close with the array/object syntax. how were you thinking?

By early return in first if case we can move variable to outer scope :)

pi0 · 2021-02-18T21:37:16Z

It think would be nice mentioning this feature in readme :)

feat: support automatic json body for post requests

0b65c53

danielroe requested review from atinux and pi0 February 18, 2021 19:48

atinux approved these changes Feb 18, 2021

View reviewed changes