fix(types): allow synchronous interceptors to be passed #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
changed the title
onRequest to be synchronous
danielroe
reviewed
Sep 23, 2022
danielroe
changed the title
onRequest to be synchronous
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 85.53% 85.53%
=======================================
Files 5 5
Lines 311 311
Branches 60 60
=======================================
Hits 266 266
Misses 45 45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My English is not good, sorry I used a translator
Hi hello, I am using onRequest in $fetch.create in nuxt3, it throws an error, need to return a Promise? But I don't return anything and it seems to be working fine.
maybe it is possible to use union types to avoid this type error?
resolves #127